dawidwys commented on a change in pull request #8865: [FLINK-12924][table] Introduce basic type inference interfaces URL: https://github.com/apache/flink/pull/8865#discussion_r297082177
########## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/CallContextBase.java ########## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.types.inference; + +import org.apache.flink.annotation.PublicEvolving; +import org.apache.flink.table.functions.FunctionDefinition; + +import java.util.Optional; + +/** + * Provides details about the function call for which type inference is performed. + */ +@PublicEvolving +public interface CallContextBase { + + /** + * Returns the function definition that defines the function currently being called. + */ + FunctionDefinition getFunctionDefinition(); + + /** + * Returns whether the argument at the given position is a value literal. + */ + boolean isArgumentLiteral(int pos); + + /** + * Returns {@code true} if the argument at the given position is a literal and {@code null}, + * {@code false} otherwise. + */ + boolean isArgumentNull(int pos); Review comment: nit: Maybe add a note the `isArgumentLiteral` should be called first? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
