dawidwys commented on a change in pull request #8819: [FLINK-12911][table-api] 
Port AppendStreamTableSink, UpsertStreamTableSink, RetractStreamTableSink to 
flink-api-java-bridge
URL: https://github.com/apache/flink/pull/8819#discussion_r297096175
 
 

 ##########
 File path: 
flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/sinks/AppendStreamTableSink.java
 ##########
 @@ -16,17 +16,20 @@
  * limitations under the License.
  */
 
-package org.apache.flink.table.sinks
+package org.apache.flink.table.sinks;
 
-import org.apache.flink.streaming.api.datastream.DataStream
-import org.apache.flink.table.api.Table
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.TableException;
 
 /**
-  * Defines an external [[TableSink]] to emit streaming [[Table]] with only 
insert changes.
-  *
-  * If the [[Table]] is also modified by update or delete changes, a
-  * [[org.apache.flink.table.api.TableException]] will be thrown.
-  *
-  * @tparam T Type of [[DataStream]] that this [[TableSink]] expects and 
supports.
-  */
-trait AppendStreamTableSink[T] extends StreamTableSink[T]
+ * Defines an external {@link TableSink} to emit streaming {@link Table} with 
only insert changes.
+ *
+ * <p>If the {@link Table} is also modified by update or delete changes, a 
{@link TableException}
+ * will be thrown.
+ *
+ * @param <T> Type of {@link DataStream} that this {@link TableSink} expects 
and supports.
+ */
+public interface AppendStreamTableSink<T> extends StreamTableSink<T> {
 
 Review comment:
   missing `@PublicEvolving`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to