azagrebin commented on a change in pull request #8687:
[FLINK-12612][coordination] Track stored partition on the TaskExecutor
URL: https://github.com/apache/flink/pull/8687#discussion_r297174284
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -1278,10 +1318,22 @@ private JobManagerConnection associateWithJobManager(
private void disassociateFromJobManager(JobManagerConnection
jobManagerConnection, Exception cause) throws IOException {
checkNotNull(jobManagerConnection);
+ final JobID jobId = jobManagerConnection.getJobID();
+
+ // cleanup remaining partitions once all tasks for this job
have completed
+ final Collection<CompletableFuture<ExecutionState>>
taskTerminationFutures = taskTerminationFuturesPerJob.remove(jobId);
+ if (taskTerminationFutures != null) {
Review comment:
should be a separate method at least
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
