NicoK opened a new pull request #8886: [FLINK-12987][metrics] fix DescriptiveStatisticsHistogram#getCount() not returning the number of elements seen URL: https://github.com/apache/flink/pull/8886 ## What is the purpose of the change `DescriptiveStatisticsHistogram#getCount()` only returned the number of currently stored elements, not the total number seen. This is different from the docs in `Histogram` and the `DropwizardHistogramWrapper` implementation and fixed by this PR. ## Brief change log - extend `HistogramStatistics` with an additional `AtomicLong` to count the number of elements seen ## Verifying this change This change added tests and can be verified as follows: - add an abstract unit test for verifying any `Histogram` implementation based on the previous test from `DropwizardFlinkHistogramWrapperTest` - create `DescriptiveStatisticsHistogramTest` to run this test with `DescriptiveStatisticsHistogram` ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): **yes** (test-jar, test-scope `flink-metrics` -> `flink-runtime`) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no** - The serializers: **no** - The runtime per-record code paths (performance sensitive): **no** - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **no** - The S3 file system connector: **no** ## Documentation - Does this pull request introduce a new feature? **no** - If yes, how is the feature documented? **not applicable**
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
