bowenli86 commented on a change in pull request #8875: [FLINK-12970][hive]
Support writing Hive complex types
URL: https://github.com/apache/flink/pull/8875#discussion_r297435669
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/util/HiveTableUtil.java
##########
@@ -146,15 +150,31 @@ public static ObjectInspector
getObjectInspector(DataType flinkType) throws IOEx
return
getObjectInspector(HiveTypeUtil.toHiveTypeInfo(flinkType));
}
- // TODO: reuse Hive's TypeInfoUtils?
private static ObjectInspector getObjectInspector(TypeInfo type) throws
IOException {
Review comment:
`HiveInspectors` also has such a method. Can we move the whole thing to
`HiveInspectors` so we have a single place to do all kinds of conversions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
