pnowojski commented on a change in pull request #8858: [hotfix][tests] Change 
some StreamTask tests to create a test task in the task's thread
URL: https://github.com/apache/flink/pull/8858#discussion_r297531416
 
 

 ##########
 File path: 
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java
 ##########
 @@ -1023,25 +1014,63 @@ protected AbstractStateBackend 
createInnerBackend(Configuration config) {
        // 
------------------------------------------------------------------------
        // 
------------------------------------------------------------------------
 
+       private enum Event {
+               TASK_IS_RUNNING,
+       }
+
        private static class EmptyStreamTask extends StreamTask<String, 
AbstractStreamOperator<String>> {
 
 Review comment:
   I'm not sure. I think that `EmptyStreamTask` is not the best, but also I 
don't think that my proposal are much better. I would lean towards 
`AwaitableStreamTask` or `AwaitableEmptyStreamTask`, but if you don't like it, 
I'm fine with leaving it as it is.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to