klion26 opened a new pull request #8895: [FLINK-12536][coordinator]Make BufferOrEventSequence#getNext non blocking URL: https://github.com/apache/flink/pull/8895 ## What is the purpose of the change Currently it is non-blocking in case of credit-based flow control (default), however for SpilledBufferOrEventSequence it is blocking on reading from file. We might want to consider reimplementing it to be non blocking with CompletableFuture<?> isAvailable() method. Otherwise we will block mailbox processing for the duration of reading from file - for example we will block processing time timers and potentially in the future network flushes. ## Brief change log Use a ByteBuffer pool to read the BufferOrEvent asynchronous. - the pool size if default 2, can be configurated by key `taskmanager.memory.async-load.buffer-count` - will reuse the read thread in `IOManager` ## Verifying this change This change is already covered by existing tests, such as: - `SpilledBufferOrEventSequenceTest.java` ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (**no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**no**) - The serializers: (**no**) - The runtime per-record code paths (performance sensitive): (**no**) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (**no**) - The S3 file system connector: (**no**) ## Documentation - Does this pull request introduce a new feature? (**no**) - If yes, how is the feature documented? (**not applicable**)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
