dianfu commented on a change in pull request #8863: [FLINK-12962][python] Allows pyflink to be pip installed. URL: https://github.com/apache/flink/pull/8863#discussion_r297550056
########## File path: flink-dist/src/main/flink-bin/bin/config.sh ########## @@ -296,7 +296,10 @@ bin=`dirname "$target"` SYMLINK_RESOLVED_BIN=`cd "$bin"; pwd -P` # Define the main directory of the flink installation -FLINK_HOME=`dirname "$SYMLINK_RESOLVED_BIN"` +# If config.sh is called by pyflink-shell.sh in python bin directory(pip installed), use the _PYFLINK_HOME +if [ -z "$_FLINK_HOME_DETERMINED" ]; then Review comment: In case that `FLINK_HOME` is already determined, `FLINK_HOME` will be set. So we can check if `FLINK_HOME` is already set and there is no need to add variable `_FLINK_HOME_DETERMINED`. What do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
