sunjincheng121 commented on a change in pull request #8892:
[FLINK-FLINK-12990][python] Date type doesn't consider the local TimeZone
URL: https://github.com/apache/flink/pull/8892#discussion_r297567725
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/util/python/PythonTableUtils.scala
##########
@@ -389,4 +394,26 @@ object PythonTableUtils {
array
}
}
+
+ private def getOffsetFromLocalMillis(millisLocal: Long): Int = {
Review comment:
It's better to add the test case for this utils method, What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
