liyafan82 commented on a change in pull request #8757: [FLINK-12850][core] Introduce TypeInfo for LocalDate/LocalTime/LocalDateTime URL: https://github.com/apache/flink/pull/8757#discussion_r297571612
########## File path: flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/LocalDateComparator.java ########## @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.api.common.typeutils.base; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.api.common.typeutils.TypeComparator; +import org.apache.flink.core.memory.DataInputView; +import org.apache.flink.core.memory.DataOutputView; +import org.apache.flink.core.memory.MemorySegment; + +import java.io.IOException; +import java.io.Serializable; +import java.time.LocalDate; + +/** + * This class can not extend {@link BasicTypeComparator}, because LocalDate is a + * Comparable of ChronoLocalDate instead of Comparable of LocalDate. + */ +@Internal +public final class LocalDateComparator extends TypeComparator<LocalDate> implements Serializable { + + private transient LocalDate reference; + + protected final boolean ascendingComparison; + + // For use by getComparators + @SuppressWarnings("rawtypes") + private final LocalDateComparator[] comparators = new LocalDateComparator[] {this}; + + public LocalDateComparator(boolean ascending) { + this.ascendingComparison = ascending; + } + + @Override + public int hash(LocalDate value) { + return value.hashCode(); + } + + @Override + public void setReference(LocalDate toCompare) { + this.reference = toCompare; + } + + @Override + public boolean equalToReference(LocalDate candidate) { + return candidate.equals(reference); + } + + @Override + public int compareToReference(TypeComparator<LocalDate> referencedComparator) { + int comp = ((LocalDateComparator) referencedComparator).reference.compareTo(reference); + return ascendingComparison ? comp : -comp; + } + + @Override + public int compare(LocalDate first, LocalDate second) { + int cmp = first.compareTo(second); + return ascendingComparison ? cmp : -cmp; + } + + @Override + public boolean invertNormalizedKey() { + return !ascendingComparison; + } + + @Override + public boolean supportsSerializationWithKeyNormalization() { + return false; + } + + @Override + public void writeWithKeyNormalization(LocalDate record, DataOutputView target) throws IOException { + throw new UnsupportedOperationException(); + } + + @Override + public int extractKeys(Object record, Object[] target, int index) { + target[index] = record; + return 1; + } + + @SuppressWarnings("rawtypes") + @Override + public TypeComparator[] getFlatComparators() { + return comparators; + } + + @Override + public LocalDate readWithKeyDenormalization(LocalDate reuse, DataInputView source) throws IOException { + throw new UnsupportedOperationException(); + } + + @Override + public int compareSerialized(DataInputView firstSource, DataInputView secondSource) throws IOException { + return compareSerializedLocalDate(firstSource, secondSource, ascendingComparison); + } + + @Override + public boolean supportsNormalizedKey() { + return true; + } + + @Override + public int getNormalizeKeyLen() { + return 6; + } + + @Override + public boolean isNormalizedKeyPrefixOnly(int keyBytes) { + return keyBytes < getNormalizeKeyLen(); + } + + @Override + public void putNormalizedKey(LocalDate record, MemorySegment target, int offset, int numBytes) { + putNormalizedKeyLocalDate(record, target, offset, numBytes); + } + + @Override + public LocalDateComparator duplicate() { + return new LocalDateComparator(ascendingComparison); + } + + // -------------------------------------------------------------------------------------------- + // Static Helpers for Date Comparison + // -------------------------------------------------------------------------------------------- + + public static int compareSerializedLocalDate(DataInputView firstSource, DataInputView secondSource, + boolean ascendingComparison) throws IOException { + int cmp = firstSource.readInt() - secondSource.readInt(); + if (cmp == 0) { + cmp = firstSource.readByte() - secondSource.readByte(); + if (cmp == 0) { + cmp = firstSource.readByte() - secondSource.readByte(); + } + } Review comment: This logic is confusing for me. Internally, the LocalDate takes up 4 bytes, but we are using 6 bytes for comparison? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
