[ 
https://issues.apache.org/jira/browse/FLINK-11956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873327#comment-16873327
 ] 

Piotr Nowojski commented on FLINK-11956:
----------------------------------------

It's hard to verify it. There is always a possibility that there is some rare 
crazy code path in a file system, that's touching \{{getContextClassLoader()}} 
not during {{FileSystem}} creation, but when for example closing it, or 
handling some timeout on write or whatever. We have some test coverage in end 
to end tests and those tests are failing if we do not set the correct context 
class loader during {{FileSystem}} creation. 

If something doesn't adhere to this rules and is randomly touching 
{{getContextClassLoader}}, then we will simply not be able to provide it as 
plugin period. This is also true for any other potential future plugins, not 
only file systems. That's why we are not planning to drop the non plugin based 
file system support and yes, it will make this Jira ticket that we are 
discussing right now, quite risky to execute without extending test coverage or 
without some production usage exposure.

Ops, now that I look at my earlier comment I didn't phrase myself correctly. By:

> deprecate non plugin {{FileSystems}}

I meant not dropping the `lib` loaded {{FileSystems}} mechanism but changing 
our recommended policy of using {{FileSystem}} jars as plugins.

I guess my main point is how do we want to roll out plugins support. And this  
{{getContextClassLoader}} issue makes it more complicated.

> Remove shading from filesystems build
> -------------------------------------
>
>                 Key: FLINK-11956
>                 URL: https://issues.apache.org/jira/browse/FLINK-11956
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Connectors / FileSystem
>    Affects Versions: 1.9.0
>            Reporter: Stefan Richter
>            Assignee: vinoyang
>            Priority: Blocker
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to