pnowojski commented on a change in pull request #8811: [FLINK-12777][network]
Support CheckpointBarrierHandler in StreamTwoInputSelectableProcessor
URL: https://github.com/apache/flink/pull/8811#discussion_r297710055
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CachedBufferStorage.java
##########
@@ -82,29 +92,30 @@ public BufferOrEventSequence
rollOverWithoutReusingResources() {
}
@Override
- public void close() {
+ public void close() throws IOException {
BufferOrEvent boe;
while ((boe = currentBuffers.poll()) != null) {
Review comment:
I'm not sure if that's the contract here. I guess this is on a best effort
basis clean up.
Regardless of that, this is a separate issue independent of my change. If
you think that something is not correct here, can you create a new issue and
investigate it there?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
