zhijiangW commented on a change in pull request #8646: [FLINK-12735][network]
Make shuffle environment implementation independent with IOManager
URL: https://github.com/apache/flink/pull/8646#discussion_r297761672
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/sort/ExternalSortLargeRecordsITCase.java
##########
@@ -71,7 +71,7 @@ public void beforeTest() {
}
@After
- public void afterTest() {
+ public void afterTest() throws Exception {
this.ioManager.close();
if (!this.ioManager.isProperlyShutDown()) {
Review comment:
After confirming with andrey, we could keep the previous behavior to still
ignore `IOException` during close, because we just try best to delete files for
releasing resources. If one file was already deleted by other factors before,
it is no need to cause unnecessary failover.
If we want to refactor this behavior future, we could do it separately, not
to block this PR. I remove `try catch` from `IOManager#close` and add some
javadoc for this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
