bowenli86 opened a new pull request #8904: [FLINK-13005][hive] HiveCatalog should not add 'flink.is_generic' key for Hive table URL: https://github.com/apache/flink/pull/8904 ## What is the purpose of the change This PR fixes a bug that 'flink.is_generic' key should not add for metadata for a non-generic catalog table (a.k.a a Hive table). Currently when we create a CatalogTable from a Hive table, if there is no 'flink.is_generic' key in the properties map, we will first add it with a default value as 'false'. ## Brief change log - made 'flink.' a catalog-wise reserved prefix key for properties - changed behavior to not add 'flink.is_generic' key when it's not in hive table's properties map - updated unit tests to cover this case ## Verifying this change This change added tests and can be verified as follows: `HiveCatalogHiveMetadataTest` ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
