Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1106#discussion_r39763329
  
    --- Diff: 
flink-staging/flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITSuite.scala
 ---
    @@ -212,6 +212,49 @@ class ScalaShellITSuite extends FunSuite with Matchers 
with BeforeAndAfterAll {
         out.toString + stdout
       }
     
    +  /**
    +   * tests flink shell startup with remote cluster (starts cluster 
internally)
    +   */
    +  test("start flink scala shell with remote cluster") {
    +
    +    val input: String = "val els = env.fromElements(\"a\",\"b\");\n" +
    --- End diff --
    
    Can you also add a check, that the program was actually executed for 
example by checking that the correct output was produced?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to