NicoK commented on a change in pull request #8668: [FLINK-12784][metrics]
Support retention policy for InfluxDB metrics …
URL: https://github.com/apache/flink/pull/8668#discussion_r298092960
##########
File path:
flink-metrics/flink-metrics-influxdb/src/test/java/org/apache/flink/metrics/influxdb/InfluxdbReporterTest.java
##########
@@ -111,7 +111,7 @@ public void testMetricReporting() throws Exception {
reporter.report();
verify(postRequestedFor(urlPathEqualTo("/write"))
- .withQueryParam("db", equalTo(TEST_INFLUXDB_DB))
+
.withQueryParam(InfluxdbReporterOptions.DB.key(), equalTo(TEST_INFLUXDB_DB))
Review comment:
Please revert this change here, since the query param is actually unrelated
to how we name our options. In my last review, I was only referring to the
`createMetricRegistry` method below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
