1u0 commented on a change in pull request #8692: [FLINK-12804] Introduce
mailbox-based ExecutorService
URL: https://github.com/apache/flink/pull/8692#discussion_r298125132
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -226,13 +219,18 @@ protected StreamTask(
this.accumulatorMap =
getEnvironment().getAccumulatorRegistry().getUserMap();
this.recordWriters = createRecordWriters(configuration,
environment);
this.syncSavepointLatch = new SynchronousSavepointLatch();
- this.mailbox = new MailboxImpl();
+ this.mailboxProcessor = new MailboxProcessor(this);
Review comment:
Currently the `MailboxDefaultAction` interface has only one abstract method.
You can write `new MailboxProcessor(this::performDefaultAction)` instead and
remove `MailboxDefaultAction` from `StreamTask implements`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services