wuchong commented on a change in pull request #8850: [FLINK-12954] Supports
create(drop) view grammar for sql parser
URL: https://github.com/apache/flink/pull/8850#discussion_r298130713
##########
File path:
flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkSqlParserImplTest.java
##########
@@ -583,6 +583,25 @@ public void testInvalidUpsertOverwrite() {
"OVERWRITE expression is only used with INSERT mode");
}
+ @Test
+ public void testCreateViewWithProperty() {
Review comment:
Please rename the method name.
Please also add some tests about create view without comment and drop view.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
