NicoK commented on issue #8215: [FLINK-8801][yarn/s3] Fix jars downloading issues due to inconsistent timestamp in S3 Filesystem URL: https://github.com/apache/flink/pull/8215#issuecomment-506382725 > > Indeed, it looks like this is the better approach. Aside from some minor details in the code, I would only have one concern which I'm not sure about: > > > > * Are we allowed to change the local resource's time? What are the implications? > > > > I guess, this is the local resource file that was uploaded to the JM and there are no further implications but I'm not 100% sure. > > Yes, Flink will need to set the local resource's time explicitly. This is also the case before your change. Can you clarify a bit on this? Where was this done? My problem is only that `Utils#setupLocalResource` is not only used for the JobManager uploading resources to remote paths but also by `Utils#createTaskExecutorContext()` to copy configuration files into the user's home directory. If we now change the timestamp of that config file, I don't know whether this would impact YARN or our own code regarding the integrity of that file.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
