xuefuz commented on issue #8890: [FLINK-12989][hive]: Generate HiveTableSink from from a Hive table URL: https://github.com/apache/flink/pull/8890#issuecomment-506418554 > @xuefuz thanks for the update! > > Just want to confirm if the approach also works for in-memory catalog, because currently users can create Hive tables in in-memory catalog. Would be better to work for both HiveCatalog (HiveTableFactory) and in-memory catalog. If we need extra work for it, it can be in the different PR. > > Otherwise LGTM with a few minor comments. Good point. I expect that GenericInMemoryCatalog will have its own table factory, which will need to process the request according to the actual table type in a similar fashion as in HiveTableFactory. However, that's a different thing with lower priority. We can do that as a followup.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
