JingsongLi commented on a change in pull request #8901:
[FLINK-13003][table-planner-blink] Support Temporal TableFunction Join in blink
planner
URL: https://github.com/apache/flink/pull/8901#discussion_r298431205
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala
##########
@@ -488,14 +488,14 @@ abstract class StreamTableEnvironment(
}
}
- fields.zipWithIndex.foreach {
- case ("rowtime", idx) =>
- extractRowtime(idx, "rowtime", None)
-
- case ("proctime", idx) =>
- extractProctime(idx, "proctime")
-
- case (name, _) => fieldNames = name :: fieldNames
+ fields.zipWithIndex.foreach { case (name, idx) =>
Review comment:
Why we change this? It seems that flink-planner has not this logical?
Flink-planner need invoke rowtime/proctime function to define a time attribute?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
