pnowojski commented on issue #8455: [FLINK-12284,FLINK-12637][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#issuecomment-506683902 > In addition, one PR should not connect to two jira tickets in general. So I think you might need to close one jira and adjust this PR to only one jira. I wouldn't be so strict about having couple of jira tickets in one PR, especially if they depend on one another. However as a rule of thumb one commit shouldn't be addressing two jira tickets, since probably it means that either: - commit is fixing two separate things - Jira tickets are duplicated As far as I recall this is inline with our coding style guideline. Of course it's better to have separate things fixed in independent PRs. Here I think it's the case that "Jira tickets are duplicated". In my opinion `Add metrics for floatingBufferUsage and exclusiveBufferUsage for credit based mode` is a solution for `InputBufferPoolUsage is incorrect in credit-based network control flow`. So I would close the newer ticket as duplicate of the older one.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
