shaoxuan-wang commented on issue #8632: [FLINK-12744][ml] add shared params in ml package URL: https://github.com/apache/flink/pull/8632#issuecomment-507031331 Thanks for the contribution, @xuyang1706 The PR looks good to me in general. But I have a few concerns about the naming of interfaces/classes. You have used many unusual abbreviations, for instance DV=>Default value, PRED=>Predicted, in several interfaces/classes, which makes them hard to understand. My feeling is that most `DV` can be replaced by `as`? If it has to be DV, please make sure to use capital characters `DV`, as oppose to `Dv`. For the case of PRED, I do not think it is necessary to shorten the word, as it only reduces a few characters but introduces the ambiguity. What do you think?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
