bowenli86 commented on a change in pull request #8935: [Flink-12973]Support 
reading Hive complex types like array and map
URL: https://github.com/apache/flink/pull/8935#discussion_r299170539
 
 

 ##########
 File path: 
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/batch/connectors/hive/HiveRecordSerDe.java
 ##########
 @@ -47,6 +56,12 @@ public static Object obtainFlinkRowField(Object field, 
ObjectInspector fieldObje
                Object res;
                if (fieldObjectInspector.getCategory() == 
ObjectInspector.Category.PRIMITIVE) {
                        res = convertPrimitiveField(field, 
(PrimitiveObjectInspector) fieldObjectInspector);
+               } else if (fieldObjectInspector.getCategory() == 
ObjectInspector.Category.STRUCT) {
 
 Review comment:
   maybe we can just use `HiveInspector.toFlinkObject()` and remove 
`obtainFlinkRowField()`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to