bowenli86 commented on issue #8926: [FLINK-13021][table][hive] unify catalog partition implementations URL: https://github.com/apache/flink/pull/8926#issuecomment-507466762 Good questions. > 1. I saw a few configuration files for Hive (table/db, etc) and each has just few constants. I'm wondering if we should just have one file that covers all those configs. Exactly. I've observed that too. I plan to merge them into a single `HiveCatalogConfig` in a following up. > 2. When we create Catalog objects (table/db/partition), we remove "comment" from the property map. I'm wondering how that changes desc command output for those objects because ideally comment should be shown, at least for extended mode. We only do that for table and partition. - Hive's `Database` has a `description` field to store comment and we use that, thus that's the same output for 'DESC' - Hive DDL for tables (e.g. `CREATE TABLE xx COMMENT xxx`) store comment as just a 'comment' property, so that's the same output for 'DESC' - AFAIK, Hive DDL doesn't support partition comment, thus it shouldn't matter how we store it in properties
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
