wuchong commented on a change in pull request #8872: [FLINK-12977][table]Port CsvTableSource to api-java-bridge URL: https://github.com/apache/flink/pull/8872#discussion_r299042199
########## File path: flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/sinks/CsvTableSink.java ########## @@ -0,0 +1,176 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.sinks; + +import org.apache.flink.api.common.functions.MapFunction; +import org.apache.flink.api.common.typeinfo.TypeInformation; +import org.apache.flink.api.java.DataSet; +import org.apache.flink.api.java.operators.DataSink; +import org.apache.flink.api.java.operators.MapOperator; +import org.apache.flink.api.java.typeutils.RowTypeInfo; +import org.apache.flink.core.fs.FileSystem; +import org.apache.flink.streaming.api.datastream.DataStream; +import org.apache.flink.streaming.api.datastream.DataStreamSink; +import org.apache.flink.streaming.api.datastream.SingleOutputStreamOperator; +import org.apache.flink.table.utils.TableConnectorUtils; +import org.apache.flink.types.Row; + +/** + * A simple [[TableSink]] to emit data as CSV files. + */ +public class CsvTableSink implements BatchTableSink<Row>, AppendStreamTableSink<Row> { + private String path; + private String fieldDelim; + private int numFiles = -1; + private FileSystem.WriteMode writeMode; + + private String[] fieldNames; + private TypeInformation<?>[] fieldTypes; + + /** + * A simple [[TableSink]] to emit data as CSV files. + * + * @param path The output path to write the Table to. + * @param fieldDelim The field delimiter + * @param numFiles The number of files to write to + * @param writeMode The write mode to specify whether existing files are overwritten or not. + */ + public CsvTableSink( + String path, + String fieldDelim, + int numFiles, + FileSystem.WriteMode writeMode) { + this.path = path; + this.fieldDelim = fieldDelim; + this.numFiles = numFiles; + this.writeMode = writeMode; + } + + /** + * A simple [[TableSink]] to emit data as CSV files using comma as field delimiter, with default + * parallelism and write mode. + * + * @param path The output path to write the Table to. + */ + public CsvTableSink(String path) { + this(path, ","); + } + + /** + * A simple [[TableSink]] to emit data as CSV files, with default parallelism and write mode. + * + * @param path The output path to write the Table to. + * @param fieldDelim The field delimiter + */ + public CsvTableSink(String path, String fieldDelim) { + this(path, fieldDelim, -1, null); + } + + @Override + public void emitDataSet(DataSet<Row> dataSet) { + MapOperator<Row, String> csvRows = + dataSet.map(new CsvFormatter(fieldDelim == null ? "," : fieldDelim)); + + DataSink<String> sink; + if (writeMode != null) { + sink = csvRows.writeAsText(path, writeMode); + } else { + sink = csvRows.writeAsText(path); + } + + if (numFiles > 0) { + csvRows.setParallelism(numFiles); + sink.setParallelism(numFiles); + } + + sink.name(TableConnectorUtils.generateRuntimeName(CsvTableSink.class, fieldNames)); + } + + @Override + @SuppressWarnings("") + public void emitDataStream(DataStream<Row> dataStream) { + SingleOutputStreamOperator<String> csvRows = + dataStream.map(new CsvFormatter(fieldDelim == null ? "," : fieldDelim)); + + DataStreamSink<String> sink; + if (writeMode != null) { + sink = csvRows.writeAsText(path, writeMode); + } else { + sink = csvRows.writeAsText(path); + } + + if (numFiles > 0) { + csvRows.setParallelism(numFiles); + sink.setParallelism(numFiles); + } + + sink.name(TableConnectorUtils.generateRuntimeName(CsvTableSink.class, fieldNames)); + } + + @Override + public TableSink<Row> configure(String[] fieldNames, TypeInformation<?>[] fieldTypes) { + CsvTableSink configuredSink = new CsvTableSink(path, fieldDelim, numFiles, writeMode); + configuredSink.fieldNames = fieldNames; + configuredSink.fieldTypes = fieldTypes; + return configuredSink; + } + + @Override + public TypeInformation<Row> getOutputType() { + return new RowTypeInfo(getFieldTypes(), getFieldNames()); + } + + @Override + public String[] getFieldNames() { + return fieldNames; + } + + @Override + public TypeInformation<?>[] getFieldTypes() { + return fieldTypes; + } + + /** + * Formats a [[Row]] into a [[String]] with fields separated by the field delimiter. + */ + public static class CsvFormatter implements MapFunction<Row, String> { + private final String fieldDelim; + + /** + * Constructor with field delimiter. + * + * @param fieldDelim The field delimiter. + */ + CsvFormatter(String fieldDelim) { + this.fieldDelim = fieldDelim; + } + + @Override + public String map(Row row) throws Exception { + StringBuilder builder = new StringBuilder(); + for (int i = 0; i < row.getArity(); i++) { + if (builder.length() != 0) { + builder.append(fieldDelim); + } + builder.append(row.getField(i)); Review comment: If `row.getField(i)` is null, it shouldn't be wrote to the builder. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
