StephanEwen commented on issue #8714: [FLINK-12820][Connectors / Cassandra] 
Support ignoring writing nulls 
URL: https://github.com/apache/flink/pull/8714#issuecomment-507579228
 
 
   Overall approach looks good.
   
   I would ask you to switch to use primitive booleans rather than boxed 
booleans, to be consistent with the approach in the remainder of Flink. This 
also avoid accidental nullability and late null pointer exceptions.
   
   Otherwise looks good to me.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to