StephanEwen commented on a change in pull request #8756: [FLINK-12406] 
[Runtime] Report BLOCKING_PERSISTENT result partition meta back to client
URL: https://github.com/apache/flink/pull/8756#discussion_r299700273
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/AccessExecutionGraph.java
 ##########
 @@ -158,6 +159,14 @@
         */
        Map<String, SerializedValue<OptionalFailure<Object>>> 
getAccumulatorsSerialized();
 
+       /**
+        * Returns a {@link BlockingPersistentResultPartitionMeta}.
+        * @return BlockingPersistentResultPartitionMeta contains 
ResultPartition locations
+        */
+       default BlockingPersistentResultPartitionMeta 
getBlockingPersistentResultPartitionMeta() {
 
 Review comment:
   I think this is a tricky use of a default methods, because this is not a 
working implementation for all subclasses, which is how default methods on 
interfaces should only be used.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to