KurtYoung commented on a change in pull request #8844: 
[FLINK-12951][table-planner] Add logic to bridge DDL to table source(…
URL: https://github.com/apache/flink/pull/8844#discussion_r299792712
 
 

 ##########
 File path: 
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTable.java
 ##########
 @@ -235,6 +236,40 @@ public String getColumnSqlString() {
                return writer.toString();
        }
 
+       /** Split the computed columns sql into string k-v pairs which are put 
into
+        * the {@code container}.
+        *
+        * <p>For example, {@code col1 as to_timestamp(col2)} would be split 
into pair:
+        * (col1, to_timestamp(col2)).
+        **/
+       public void getComputedColumnExpressions(List<Pair<String, String>> 
container) {
 
 Review comment:
   useless?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to