pnowojski commented on a change in pull request #8826: [FLINK-12479][operators] 
Integrate StreamInputProcessor(s) with mailbox
URL: https://github.com/apache/flink/pull/8826#discussion_r299877889
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
 ##########
 @@ -211,6 +211,34 @@ public void setup() throws IOException {
 
                BufferPool bufferPool = bufferPoolFactory.get();
                setBufferPool(bufferPool);
+
+               requestPartitions();
+       }
+
+       private void requestPartitions() throws IOException, 
InterruptedException {
+               synchronized (requestLock) {
+                       if (!requestedPartitionsFlag) {
 
 Review comment:
   That might be not that simple, since this flag is also used during 
`updateInputChannel` from unknown channel. I'm not sure, but update probably 
can happen concurrently to the setup.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to