AjaxXu commented on a change in pull request #8961:
[FLINK-13073][table-blink-runtime]BinaryRow in Blink runtime has wrong
FIRST_BYTE_ZERO mask
URL: https://github.com/apache/flink/pull/8961#discussion_r299969659
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/dataformat/BinaryRow.java
##########
@@ -55,7 +55,7 @@
public final class BinaryRow extends BinaryFormat implements BaseRow {
public static final boolean LITTLE_ENDIAN = (ByteOrder.nativeOrder() ==
ByteOrder.LITTLE_ENDIAN);
- private static final long FIRST_BYTE_ZERO = LITTLE_ENDIAN ? 0xFFF0 :
0x0FFF;
+ private static final long FIRST_BYTE_ZERO = LITTLE_ENDIAN ?
0xFFFFFFFFFFFFFF00L : 0x00FFFFFFFFFFFFFFL;
Review comment:
After test, it seems to that have the same expression with
0xFFFFFFFFFFFFFF00L and 0x00FFFFFFFFFFFFFFL, I am going to use the short
expression.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
