[ 
https://issues.apache.org/jira/browse/FLINK-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14875879#comment-14875879
 ] 

ASF GitHub Bot commented on FLINK-2576:
---------------------------------------

Github user jkovacs commented on the pull request:

    https://github.com/apache/flink/pull/1138#issuecomment-141497981
  
    Thanks @fhueske, that's a good point I haven't considered. 
    
    Another idea that occurred to me was to convert the result tuple types to 
`GenericTypeInfo<T>` (instead of `GenericTypeInfo<Object>`), where `T` is the 
original type of the tuple field (e.g. `String` or `Integer`). This would be 
null safe _and_ would allow the user to group by those fields, assuming of 
course they are sure that the fields are non-null (e.g. on a left or right 
outer join).
    Although I'm not sure of all the consequences of using, say, 
`GenericTypeInfo<String>` instead of `BasicTypeInfo<String>` for serialization 
and comparison.
    
    I pushed this change as 
https://github.com/jkovacs/flink/commit/f682baa50137e0a54bae091ba60ba85fdb8f4c1b
 to a different branch to test it 
    
    Also rebased branch onto current master and resolved conflicts (Failing 
test is some YARN integration test).


> Add outer joins to API and Optimizer
> ------------------------------------
>
>                 Key: FLINK-2576
>                 URL: https://issues.apache.org/jira/browse/FLINK-2576
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Java API, Optimizer, Scala API
>            Reporter: Ricky Pogalz
>            Priority: Minor
>             Fix For: pre-apache
>
>
> Add left/right/full outer join methods to the DataSet APIs (Java, Scala) and 
> to the optimizer of Flink.
> Initially, the execution strategy should be a sort-merge outer join 
> (FLINK-2105) but can later be extended to hash joins for left/right outer 
> joins.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to