tzulitai commented on a change in pull request #8861:
[FLINK-12963][state-processor-api] Add savepoint writer for bootstrapping new
savepoints
URL: https://github.com/apache/flink/pull/8861#discussion_r300136394
##########
File path:
flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/api/runtime/metadata/SavepointMetadata.java
##########
@@ -20,32 +20,38 @@
import org.apache.flink.annotation.Internal;
import org.apache.flink.runtime.checkpoint.MasterState;
-import org.apache.flink.runtime.checkpoint.OperatorState;
-import java.io.IOException;
import java.io.Serializable;
import java.util.Collection;
/**
* Returns metadata about a savepoint.
*/
@Internal
-public interface SavepointMetadata extends Serializable {
+public class SavepointMetadata implements Serializable {
Review comment:
I don't think we need this base class anymore (at least from the current
state of the code). It's only subclass is the `ModifiableSavepointMetadata`.
Moreover, the contents of this base class doesn't seem to justify as a
proper savepoint metadata anyways, since it only maintains the master states.
Therefore, I would suggest to simplify the hierarchy and just have a single
`SavepointMetadata` class for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
