wuchong commented on a change in pull request #8937: [FLINK-13040] promote
blink table config and add to document
URL: https://github.com/apache/flink/pull/8937#discussion_r300217863
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/api/TableConfig.scala
##########
@@ -200,9 +202,20 @@ class TableConfig {
}
}
+ def getMillisecondFromConfigDuration(config: ConfigOption[String]): Long = {
+ val duration = Duration.create(this.conf.getString(config))
Review comment:
TableConfig will be moved to `api-java` module before 1.9 release, it will
not depend on scala. So I think we should implement the parser ourselves or
find other alternatives.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
