danny0405 commented on a change in pull request #8844:
[FLINK-12951][table-planner] Add logic to bridge DDL to table source(…
URL: https://github.com/apache/flink/pull/8844#discussion_r300221812
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnvironment.java
##########
@@ -287,6 +287,46 @@
@Deprecated
String[] getCompletionHints(String statement, int position);
+ /**
+ * Evaluates mixed-in sql statements including DDLs and DMLs.
+ * Note: Always use this interface to execute a sql query if no {@link
Table}
+ * result are expected, else use {@link #sqlQuery(String)}.
Review comment:
The sqlQuery should returns a Table object which will make the semantics of
the interface not that clear, say: how about we have a sql select statement
among the multiple statements ? It does not make any sense if we support a
single select select statement but return nothing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
