beyond1920 commented on a change in pull request #8977:
[FLINK-13071][table-planner-blink] QueryOperationConverter in Blink planner
support add kinds of QueryOperations.
URL: https://github.com/apache/flink/pull/8977#discussion_r300277644
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/expressions/RexNodeConverter.java
##########
@@ -107,16 +310,16 @@ public RexNode visit(CallExpression call) {
.collect(Collectors.toList());
}
- private RexNode translateScalarCall(FunctionDefinition def,
List<Expression> children) {
+ private RexNode visitBuiltInFunc(FunctionDefinition def,
List<Expression> children) {
- if (def.equals(BuiltInFunctionDefinitions.CAST)) {
+ if (BuiltInFunctionDefinitions.CAST.equals(def)) {
RexNode child = children.get(0).accept(this);
TypeLiteralExpression type = (TypeLiteralExpression)
children.get(1);
return relBuilder.getRexBuilder().makeAbstractCast(
typeFactory.createFieldTypeFromLogicalType(
type.getOutputDataType().getLogicalType().copy(child.getType().isNullable())),
child);
- } else if
(def.equals(BuiltInFunctionDefinitions.REINTERPRET_CAST)) {
+ } else if
(BuiltInFunctionDefinitions.REINTERPRET_CAST.equals(def)) {
Review comment:
good catch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
