TsReaper commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink URL: https://github.com/apache/flink/pull/8682#discussion_r300349163
########## File path: flink-table/flink-table-runtime-blink/src/test/java/org/apache/flink/table/typeutils/BaseMapSerializerTest.java ########## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.typeutils; + +import org.apache.flink.api.common.typeutils.SerializerTestBase; +import org.apache.flink.table.api.DataTypes; +import org.apache.flink.table.dataformat.BaseMap; +import org.apache.flink.table.dataformat.BinaryArray; +import org.apache.flink.table.dataformat.BinaryArrayWriter; +import org.apache.flink.table.dataformat.BinaryMap; +import org.apache.flink.table.dataformat.BinaryString; +import org.apache.flink.table.dataformat.GenericMap; +import org.apache.flink.testutils.DeeplyEqualsChecker; + +import java.util.HashMap; +import java.util.Map; + +/** + * A test for the {@link BaseMapSerializer}. + */ +public class BaseMapSerializerTest extends SerializerTestBase<BaseMap> { + + public BaseMapSerializerTest() { + super(new DeeplyEqualsChecker().withCustomCheck( + (o1, o2) -> o1 instanceof BaseMap && o2 instanceof BaseMap, + (o1, o2, checker) -> newSer().toBinaryMap((BaseMap) o1).equals(newSer().toBinaryMap((BaseMap) o2)) Review comment: I think it's more proper to compare the maps after changing them to Java maps instead of binary maps. For example, consider the following two maps: {1: 'a', 2: 'b', 3: 'c'} and {3: 'c', 2: 'b', 1: 'a'} These are actually the same maps, but their key / value order will be different when stored as binary maps, and the equalsTo method of binary map will return false. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
