StephanEwen commented on a change in pull request #8740: [FLINK-12763][runtime]
Fail job immediately if tasks’ resource needs can not be satisfied.
URL: https://github.com/apache/flink/pull/8740#discussion_r300364535
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/ConfigurationUtils.java
##########
@@ -113,6 +113,17 @@ public static MemorySize
getTaskManagerHeapMemory(Configuration configuration) {
return splitPaths(configValue);
}
+ public static Time
getStandaloneSlotResourcesRegistrationTimeout(Configuration configuration) {
+ final Time timeout;
+ if
(configuration.contains(ResourceManagerOptions.STANDALONE_SLOT_RESOURCES_REGISTRATION_TIMEOUT)
&&
Review comment:
This uses three accesses (config map lookups). You can do it with one lookup
and then checking the result value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
