godfreyhe commented on a change in pull request #8984:
[FLINK-13088][table-api] Support lazy query transformation & execution on
TableEnvironment
URL: https://github.com/apache/flink/pull/8984#discussion_r300402774
##########
File path:
flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/api/java/internal/StreamTableEnvironmentImpl.java
##########
@@ -305,6 +327,11 @@ protected void validateTableSource(TableSource<?>
tableSource) {
validateTimeCharacteristic(TableSourceValidation.hasRowtimeAttribute(tableSource));
}
+ @Override
+ protected boolean shouldTranslateEagerly() {
+ return true;
Review comment:
blink planner will also use this class, if i understand correctly. so here
could not return true deterministically.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
