dawidwys commented on a change in pull request #8984: [FLINK-13088][table-api]
Support lazy query transformation & execution on TableEnvironment
URL: https://github.com/apache/flink/pull/8984#discussion_r300406916
##########
File path:
flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/api/java/internal/StreamTableEnvironmentImpl.java
##########
@@ -305,6 +327,11 @@ protected void validateTableSource(TableSource<?>
tableSource) {
validateTimeCharacteristic(TableSourceValidation.hasRowtimeAttribute(tableSource));
}
+ @Override
+ protected boolean shouldTranslateEagerly() {
+ return true;
Review comment:
Correct, we wanted to leave it this way. The thing is if we use this class
we should not allow lazy translation. All `toDataStream` conversion must be
translated eagerly. If we allowed for other transformations to be executed
lazily then some parts would be executed lazily and others eagerly. This poses
many problems. How do we handle DML? DCLs commands if some are executed eagerly
and others lazily.
Another problem is what happens if the user calls `execute` on
`StreamExecutionEnvironment`, which queries will be executed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
