pnowojski commented on a change in pull request #8621:
[FLINK-12682][connectors] StringWriter support custom row delimiter
URL: https://github.com/apache/flink/pull/8621#discussion_r300411710
##########
File path:
flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/StringWriter.java
##########
@@ -40,12 +40,18 @@
private transient Charset charset;
+ private String rowDelimiter;
Review comment:
Could you mark `rowDelimeter` and `rowDelimiterBytes` fields final (and set
them in the constructor) as @StephanEwen suggested? `charsetName` could also be
final.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
