godfreyhe commented on a change in pull request #8980: [FLINK-13040] promote
blink table config
URL: https://github.com/apache/flink/pull/8980#discussion_r300522345
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/api/PlannerConfigOptions.java
##########
@@ -52,95 +54,117 @@
public static final ConfigOption<Boolean>
SQL_OPTIMIZER_SHUFFLE_PARTIAL_KEY_ENABLED =
key("sql.optimizer.shuffle.partial-key.enabled")
.defaultValue(false)
- .withDescription("Enables shuffle by
partial partition keys. " +
+ .withDescription("Enables shuffling by
partial partition keys. " +
"For example, A join
with join condition: L.c1 = R.c1 and L.c2 = R.c2. " +
"If this flag is
enabled, there are 3 shuffle strategy:\n " +
"1. L and R shuffle by
c1 \n" +
"2. L and R shuffle by
c2\n" +
"3. L and R shuffle by
c1 and c2\n" +
"It can reduce some
shuffle cost someTimes.");
+ @Documentation.ExcludeFromDocumentation(value = "Temporary solution to
enable optimization that removes redundant sort for SortMergeJoin, " +
+ "and this config option will be removed later.")
public static final ConfigOption<Boolean>
SQL_OPTIMIZER_SMJ_REMOVE_SORT_ENABLED =
- key("sql.optimizer.smj.remove-sort.enabled")
+ key("sql.optimizer.sort-merge-join.remove-sort.enabled")
.defaultValue(false)
.withDescription("When true, the
optimizer will try to remove redundant sort for SortMergeJoin. " +
"However that will
increase optimization time. Default value is false.");
- public static final ConfigOption<Long>
SQL_OPTIMIZER_HASH_JOIN_BROADCAST_THRESHOLD =
- key("sql.optimizer.hash-join.broadcast.threshold")
+ public static final ConfigOption<Long>
SQL_OPTIMIZER_BROADCAST_JOIN_THRESHOLD =
+ key("sql.optimizer.broadcast.join.threshold")
Review comment:
sql.optimizer.join.broadcast.threshold ? i think `broadcast` and `threshold`
should be close, because `threshold` limits size of `broadcast`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
