Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1105#issuecomment-141769161
Hey @andralungu,
I left some minor comments. Apart from those, I think we should also
address the previous comments on (a) returning an `Integer` instead of
`Tuple1`, (b) generic vertex keys and (c) allowing any vertex and edge value
type and replace them internally with `NullValue`.
I know that other library methods also have these problems (and there's a
JIRA), but this PR is open, so we can at least fix them for this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
