wuchong commented on a change in pull request #8923: [FLINK-13026][jdbc] 
Introduce JDBCLookupFunction
URL: https://github.com/apache/flink/pull/8923#discussion_r300550448
 
 

 ##########
 File path: 
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCUtils.java
 ##########
 @@ -150,4 +150,67 @@ public static void setField(PreparedStatement upload, int 
type, Row row, int ind
                        }
                }
        }
+
+       public static Object getFieldFromResultSet(int index, int type, 
ResultSet set) throws SQLException {
+               if (set.wasNull()) {
+                       return null;
+               }
+
+               switch (type) {
+                       case java.sql.Types.NULL:
+                               return null;
+                       case java.sql.Types.BOOLEAN:
+                       case java.sql.Types.BIT:
+                               return set.getBoolean(index + 1);
+                       case java.sql.Types.CHAR:
+                       case java.sql.Types.NCHAR:
+                       case java.sql.Types.VARCHAR:
+                       case java.sql.Types.LONGVARCHAR:
+                       case java.sql.Types.LONGNVARCHAR:
+                               return set.getString(index + 1);
+                       case java.sql.Types.TINYINT:
+                               return set.getByte(index + 1);
+                       case java.sql.Types.SMALLINT:
+                               return set.getShort(index + 1);
+                       case java.sql.Types.INTEGER:
+                               return set.getInt(index + 1);
+                       case java.sql.Types.BIGINT:
+                               return set.getLong(index + 1);
+                       case java.sql.Types.REAL:
+                               return set.getFloat(index + 1);
+                       case java.sql.Types.FLOAT:
+                       case java.sql.Types.DOUBLE:
+                               return set.getDouble(index + 1);
+                       case java.sql.Types.DECIMAL:
+                       case java.sql.Types.NUMERIC:
+                               return set.getBigDecimal(index + 1);
+                       case java.sql.Types.DATE:
+                               return set.getDate(index + 1);
+                       case java.sql.Types.TIME:
+                               return set.getTime(index + 1);
+                       case java.sql.Types.TIMESTAMP:
+                               return set.getTimestamp(index + 1);
+                       case java.sql.Types.BINARY:
+                       case java.sql.Types.VARBINARY:
+                       case java.sql.Types.LONGVARBINARY:
+                               return set.getBytes(index + 1);
+                       default:
+                               LOG.warn("Unmanaged sql type ({}) for column 
{}. Best effort approach to get its value: {}.",
+                                               type, index + 1);
 
 Review comment:
   value missed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to