JingsongLi commented on issue #8923: [FLINK-13026][jdbc] Introduce JDBCLookupFunction URL: https://github.com/apache/flink/pull/8923#issuecomment-508689526 > Thanks @JingsongLi , overall looks good to me. > > However, I find that we have so many `Builder`s and not all the methods of the Builders need to be called. Can we add some javadoc to them, which are mandatory and which are optional. Yeah, I will add comments to all method. (required and optional)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
