wuchong commented on a change in pull request #8930: [FLINK-12955] HBase LookupableTableSource URL: https://github.com/apache/flink/pull/8930#discussion_r300619512
########## File path: flink-connectors/flink-hbase/src/main/java/org/apache/flink/connectors/hbase/util/HBaseConfigurationUtil.java ########## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connectors.hbase.util; + +import org.apache.flink.annotation.Internal; + +import java.io.IOException; + +/** + * This class helps to do serialization for hadoop Configuration. + */ +@Internal +public class HBaseConfigurationUtil { + + public static byte[] serializeConfiguration(org.apache.hadoop.conf.Configuration conf) throws IOException { + return WritableSerializer.serializeWritable(conf); + } + + public static org.apache.hadoop.conf.Configuration deserializeConfiguration( + byte[] serializedConfig, + org.apache.hadoop.conf.Configuration targetConfig) throws IOException { + if (null == targetConfig) { + targetConfig = new org.apache.hadoop.conf.Configuration(); + } + WritableSerializer.deserializeWritable(targetConfig, serializedConfig); Review comment: Can we merge `WritableSerializer` into this file? From the point of my view, `WritableSerializer` is a serializer class/instance (may extends `TypeSerializer`) which can serialize Writable classes. However, it is just a utility. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
