bowenli86 edited a comment on issue #9001: [FLINK-13110][hive] Fix Hive-1.2.1 build URL: https://github.com/apache/flink/pull/9001#issuecomment-508835425 LGTM @lirui-apache thanks for fixing the problem! I agree that we should be careful and should test hive-1.2.1 profile for every change since now locally before CI runs for hive-1.2.1. Just a side note that we can probably rename the JIRA and PR to something like "add shim of SimpleGenericUDAFParameterInfo for Hive 1.2.1 and 2.3.4" to be more clear on what it's about. @zentol I looked at the build failures in detail. Please correct me if I'm wrong - I believe they are not related, as this PR only affects flink-connector-hive module.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
