bowenli86 commented on issue #8920: [FLINK-13024][table] integrate FunctionCatalog with CatalogManager URL: https://github.com/apache/flink/pull/8920#issuecomment-508877866 Hi @twalthr , thanks for your feedback! I believe cutting the scope to only support Hive UDFs makes sense given the limited time left for 1.9 feature freeze. I'm not sure about merging FunctionCatalog into CatalogManager, CatalogManager has many APIs and responsibilities that have nothing to do with functions, merging FunctionCatalog and CatalogManager seems will expose many parts of the planner with a lot of information that they don't need to know. The latest push incorporates changes that adds `FunctionDefinitionFactory`, `HiveFunctionDefinitionFactory`, and support of only reading Hive UDFs in `FunctionCatalog`. The most critical part that's missing now is `FunctionLooup.lookupFunction` API should pass in an array of Expressions to get literals and input arg types, in order to instantiate Hive functions, compute the result/accumulator type, and create corresponding FunctionDefinition. Are you able to fill this gap anytime soon, hopefully in 1.9? cc @xuefuz @KurtYoung @JingsongLi @dawidwys
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
