HuangZhenQiu commented on a change in pull request #8303: [FLINK-12343]add file
replication config for yarn configuration
URL: https://github.com/apache/flink/pull/8303#discussion_r300810328
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
##########
@@ -1076,6 +1095,10 @@ private Path getYarnFilesDir(final ApplicationId appId)
throws IOException {
* local path to the file
* @param localResources
* map of resources
+ * @param relativeTargetPath
+ * relative target path
Review comment:
Agree. But given this diff also add one more parameter in the function. I
think it is safe to complete all of other missing comments. How do you think/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
