XuPingyong commented on a change in pull request #8980: [FLINK-13040] improve 
blink table config
URL: https://github.com/apache/flink/pull/8980#discussion_r300845038
 
 

 ##########
 File path: 
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/api/TableConfigOptions.java
 ##########
 @@ -31,16 +31,9 @@
        // 
------------------------------------------------------------------------
        //  Source Options
        // 
------------------------------------------------------------------------
-
-       public static final ConfigOption<Boolean> 
SQL_EXEC_SOURCE_VALUES_INPUT_ENABLED =
-                       key("sql.exec.source.values-input.enabled")
-                                       .defaultValue(false)
-                                       .withDescription("Whether support 
values source input. The reason for disabling this " +
-                                                                       
"feature is that checkpoint will not work properly when source finished.");
-
-       public static final ConfigOption<Long> SQL_EXEC_SOURCE_IDLE_TIMEOUT =
-                       key("sql.exec.source.idle.timeout.ms")
-                                       .defaultValue(-1L)
+       public static final ConfigOption<String> SQL_EXEC_SOURCE_IDLE_TIMEOUT =
 
 Review comment:
   Thanks, have checked, its description is correct.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to